tools: replace deprecated iteritems() for items() #31528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a Built-In change in Python 3 used by compile_commands_json.py to generate compile_commands_json.json. Node.js dropped Python 2 support in this script, `items()` works as expected replacement.
nodejs-github-bot
added
build
richardlau
approved these changes
Jan 26, 2020
cjihrig
approved these changes
Jan 27, 2020
richardlau
added
the
python
JungMinu
approved these changes
Jan 27, 2020
Trott
approved these changes
Jan 28, 2020
|
@nodejs/python |
cclauss
approved these changes
Jan 28, 2020
bnoordhuis
approved these changes
Jan 28, 2020
|
For reference, here's the equivalent commit to the version of |
This comment has been minimized.
This comment has been minimized.
|
Landed in 64161f2 |
Trott
pushed a commit
that referenced
this pull request
Jan 29, 2020
This is a Built-In change in Python 3 used by compile_commands_json.py to generate compile_commands_json.json. Node.js dropped Python 2 support in this script, `items()` works as expected replacement. PR-URL: #31528 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
This is a Built-In change in Python 3 used by compile_commands_json.py to generate compile_commands_json.json. Node.js dropped Python 2 support in this script, `items()` works as expected replacement. PR-URL: #31528 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
This is a Built-In change in Python 3 used by compile_commands_json.py to generate compile_commands_json.json. Node.js dropped Python 2 support in this script, `items()` works as expected replacement. PR-URL: #31528 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
This is a Built-In change in Python 3 used by compile_commands_json.py to generate compile_commands_json.json. Node.js dropped Python 2 support in this script, `items()` works as expected replacement. PR-URL: #31528 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
This is a Built-In change in Python 3 used by compile_commands_json.py to generate compile_commands_json.json. Node.js dropped Python 2 support in this script, `items()` works as expected replacement. PR-URL: #31528 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Built-In change in Python 3 used by compile_commands_json.py
to generate compile_commands_json.json. Node.js dropped Python 2 support
in this script,
items()works as expected replacement.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes